Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug in flattened detector ID calculation #54

Closed
gschramm opened this issue Nov 4, 2024 · 0 comments · Fixed by #56
Closed

bug in flattened detector ID calculation #54

gschramm opened this issue Nov 4, 2024 · 0 comments · Fixed by #56
Assignees
@KrisThielemans

Comments

@gschramm
Copy link
Collaborator

gschramm commented Nov 4, 2024

The calculation of the flattened detector ID in the python generator example is wrong:

PETSIRD/python/petsird_generator.py

Line 72 in ae3a048

rep_volume.ids.append(rep0 + N0 * (rep1 + N1 * rep2))

Should read:

rep_volume.ids.append(rep2 + N2 * (rep1 + N1 * rep0))

since rep2 is increasing the fastest.
@KrisThielemans KrisThielemans self-assigned this Nov 4, 2024
KrisThielemans added a commit to KrisThielemans/PRDdefinition that referenced this issue Nov 4, 2024
@KrisThielemans
fix module_id order
a167a55 
Fixes ETSInitiative#54
@KrisThielemans KrisThielemans mentioned this issue Nov 4, 2024
Merged
KrisThielemans added a commit that referenced this issue Nov 7, 2024
@KrisThielemans
Helper/generator fixes (#56)
f8616f8 
* fix module_id order

Fixes #54

* fix conversion from detector_id to mod/el

follow agreed order

fixes #55

* simplify id generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KrisThielemans KrisThielemans

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Helper/generator fixes KrisThielemans/PRDdefinition
2 participants
@KrisThielemans @gschramm