Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting -mlarge compilation for MSP430 #913

Closed
ReneCanadian opened this issue Jul 5, 2024 · 4 comments · Fixed by #935
Closed

Supporting -mlarge compilation for MSP430 #913

ReneCanadian opened this issue Jul 5, 2024 · 4 comments · Fixed by #935
Assignees

Comments

@ReneCanadian
Copy link
Contributor

ReneCanadian commented Jul 5, 2024

Hi!

The issue concerns building projects for 20 bit architecture for MSP430s. Currently anything that uses integral_limits.h for example span.h will crash. The work around that I found to this is adding a definition for int_20 in integral_limits.h

     template<>
     struct integral_limits<__int20 unsigned> {
         static constexpr __int20 unsigned max = 0xFFFFF;
         static constexpr __int20 unsigned min = 0;
     };

However this has to be wrapped in an #ifdef as this is not compliant with ISO C++ forcing to disable -pedantic flag.

Do we consider this should be supported within the ETL library?

@jwellbelove
Copy link
Contributor

Would you like to add this as a pull request?

@ReneCanadian
Copy link
Contributor Author

Sure! I'll try to get something ready over the weekend :)

@jwellbelove
Copy link
Contributor

Are you still planning to do a PR?

@ReneCanadian
Copy link
Contributor Author

Ah yes sorry I'll try to have it this week, got a bit side tracked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

2 participants