Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use iris.FUTURE.save_split_attrs = True to remove iris warning in many diagnostics #3651

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Jun 11, 2024

Description

Remove iris warnings similar to ESMValGroup/ESMValCore#2398.

In this PR this is only done for the diagnostics I know well. If desired, I can add this to all of them, but there might be the potential of recipe failures.


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number of pull requests:

@schlunma schlunma added this to the v2.11.0 milestone Jun 11, 2024
@schlunma schlunma requested a review from valeriupredoi June 11, 2024 09:27
@schlunma schlunma self-assigned this Jun 11, 2024
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even better, maybe move the iris imports and set it once in esmvaltool/diag_scripts/shared/__init__.py? If not, I think iris_helpers.py needs it too

@schlunma
Copy link
Contributor Author

even better, maybe move the iris imports and set it once in esmvaltool/diag_scripts/shared/__init__.py? If not, I think iris_helpers.py needs it too

It's probably clearer to have it explicitly in a file. As far as I can tell, iris_helpers.py does not have a iris.save call.

@schlunma
Copy link
Contributor Author

I merge this now to make sure it is included in v2.11.0. I tested most affected recipes, and the output looks fine 👍

@valeriupredoi
Copy link
Contributor

ah yeah sorry Manu - that's why I approved, am not too fussed about my optional suggestion, go for it! if you wanna see docs hell, have a look at the Autoapi PR I am working on, that's why I got distracted off this one 🍺 Make sure to ping @chrisbillowsMO to be sure-sure this is included in the El Releaso

@schlunma
Copy link
Contributor Author

No problem! There is no release branch in ESMValTool yet, so no need to cherry-pick anything 👍

@schlunma schlunma merged commit 7719d30 into main Jun 11, 2024
8 checks passed
@schlunma schlunma deleted the remove_iris_warnings branch June 11, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants