Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version to dataset in python example recipe to avoid "Unknown file format" issue on JASMIN #3322

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Add version to dataset in python example recipe to avoid "Unknown file format" issue on JASMIN #3322

merged 1 commit into from
Aug 24, 2023

Conversation

ehogan
Copy link
Contributor

@ehogan ehogan commented Aug 11, 2023 •
edited
Loading

Description

Is there any reason why we can't add the version to dataset for the python example recipe?

I tested the recipe on JASMIN with these changes and it works :)

Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic

To help with the number of pull requests:

@ehogan ehogan requested a review from bouweandela August 11, 2023 16:09
@ehogan ehogan self-assigned this Aug 11, 2023
@bouweandela
Copy link
Member

@esmvalbot Please run examples/recipe_python.yml

@esmvalbot
Copy link

esmvalbot bot commented Aug 14, 2023

Since @bouweandela asked, ESMValBot will run recipe examples/recipe_python.yml as soon as possible, output will be generated here

@bouweandela
Copy link
Member

@ehogan Thanks for opening this pull request. Could you please go over the pull request checklist and tick any boxes that are relevant and remove what is not relevant?

@esmvalbot
Copy link

esmvalbot bot commented Aug 14, 2023

ESMValBot is happy to report recipe examples/recipe_python.yml ran OK, output has been generated here

@ehogan
Copy link
Contributor Author

ehogan commented Aug 15, 2023

@ehogan Thanks for opening this pull request. Could you please go over the pull request checklist and tick any boxes that are relevant and remove what is not relevant?

Thanks @bouweandela 😊 I removed a few of the checklist items and ticked the rest; I hope that's all ok?

@bouweandela bouweandela removed the bug label Aug 24, 2023
@bouweandela
Copy link
Member

Thanks! I removed the bug label because I do not consider the presence of corrupted data on Jasmin a bug in ESMValTool.

@remi-kazeroni
Copy link
Contributor

Thanks for adjusting the recipe, @ehogan! And thanks for the review, @bouweandela! All looks good to me too! Merging now 👍

@remi-kazeroni remi-kazeroni merged commit 0d2b68d into main Aug 24, 2023
@remi-kazeroni remi-kazeroni deleted the 3162_add_version_to_python_recipe_dataset branch August 24, 2023 11:34
ehogan added a commit that referenced this pull request Aug 30, 2023
@ehogan
Merge branch 'recipe_test_workflow_prototype' into 3060_add_jasmin_to…
95ae33b 
…_RTW

* recipe_test_workflow_prototype: (237 commits)
  Add version to dataset in python example recipe to avoid "Unknown file format" issue on JASMIN (#3322)
  CMORizer for NASA MERRA reanalysis (#3039)
  Add `OBS-maintainers` team to documentation on OBS data maintenance and CMORizer reviews (#3335)
  Fixed provenance tracking for NCL multipanel PNGs (#3332)
  Cmorizer for NOAA-CIRES-20CR v3 reanalysis (clt, clwvi, hus, prw, rlut, rlutcs, rsut, rsutcs) (#3137)
  [Condalock] Update Linux condalock file (#3321)
  Slight refactoring of diag `galytska23/select_variables_for_tigramite.py` for generality and portability (for Changelog v2.10: authors: @valeriupredoi and @egalytska) (#3298)
  Removed recipe_carvalhais14nat from list of broken recipes (#3319)
  add Romain Beucher to CITATION as contributor (#3318)
  update `mamba` version in readthedocs configuration docs builds (#3310)
  [Github Actions] Compress all bash shell setters into one default option per workflow (#3315)
  [condalock] update conda lock creation Github Action workflow and ship updated (bot-generated) conda-lock file (#3307)
  Allow NCL unit conversion `kg s-1` -> `GtC y-1` (#3300)
  Add list of failing recipes for v2.9.0 release (#3294)
  Update diag_shapeselect.py to work with shapely v2 (#3283)
  Update release schedule after release of v2.9.0 (#3289)
  Add merge instructions to release instructions (#3292)
  Made sklearn test backwards-compatible with sklearn < 1.3 (#3285)
  Add release notes for v2.9 (#3266)
  Add release notes for v2.9 (#3266)
  ...
@ehogan ehogan mentioned this pull request Oct 6, 2023
Closed
jvegreg pushed a commit that referenced this pull request Jan 14, 2024
@ehogan
Add version to dataset in python example recipe to avoid "Unknown fil…
0e4c8f9 
…e format" issue on JASMIN (#3322)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bouweandela bouweandela bouweandela approved these changes

Assignees

@ehogan ehogan

Labels
Data
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

directory search order for CMIP data sets
3 participants
@ehogan @bouweandela @remi-kazeroni