Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropped Python 3.7 #2585

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Dropped Python 3.7 #2585

merged 1 commit into from
Mar 10, 2022

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Mar 10, 2022

Description

See discussion here: #2584. On OSX, Python 3.7 is no longer supported by conda-forge.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number of pull requests:

@schlunma schlunma merged commit 27f1148 into main Mar 10, 2022
@schlunma schlunma deleted the drop_py37 branch March 10, 2022 15:06
Copy link

@zklaus zklaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some mini changes to help us in the future.

@@ -56,7 +56,7 @@ jobs:
# runs-on: "macos-latest"
# strategy:
# matrix:
# python-version: [3.7, 3.8, 3.9]
# python-version: [3.8, 3.9, 3.10]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# python-version: [3.8, 3.9, 3.10]
# python-version: ["3.8", "3.9", "3.10"]

@@ -70,7 +70,7 @@ jobs:
# runs-on: "macos-latest"
# strategy:
# matrix:
# python-version: [3.7, 3.8, 3.9]
# python-version: [3.8, 3.9, 3.10]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# python-version: [3.8, 3.9, 3.10]
# python-version: ["3.8", "3.9", "3.10"]

@@ -56,7 +56,7 @@ jobs:
# runs-on: "macos-latest"
# strategy:
# matrix:
# python-version: [3.7, 3.8, 3.9]
# python-version: [3.8, 3.9, 3.10]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# python-version: [3.8, 3.9, 3.10]
# python-version: ["3.8", "3.9", "3.10"]

@zklaus
Copy link

zklaus commented Mar 10, 2022

D'oh. Too late I guess. That's ok.

@schlunma
Copy link
Contributor Author

Sorry! Will include these small changes in the changelog update that is coming soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSX Test and Monitor Test GA tests are failing for all Pythons
3 participants