Remove --use-feature=2020-resolver command line option for obsolete pip 2020 solver
#2493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valeriupredoi
changed the title
--use-2020solver option for pip 2020 solver--use-feature=2020-resolver command line option for obsolete pip 2020 solver
zklaus
approved these changes
Jan 21, 2022
|
cheers @zklaus - I did that for Core already, we merged it last week. TBH no idea why it's only for one lonely test 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pip introduced a more robust but different dependency resolver back when were were all working from home (sneaky! 😁 ), see communication release and that was breaking some stuffs back then, now it's the default resolver and the call to use the older resolver is deprecated and will introduce an error if used 👍 🍺
Just like in ESMValGroup/ESMValCore#1357
Tests all ok bar one related to pymon-journal that @zklaus has already flagged
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.