Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmorize gpcc masking #1995

Merged
merged 10 commits into from
Feb 17, 2021
Merged

Cmorize gpcc masking #1995

merged 10 commits into from
Feb 17, 2021

Conversation

mwjury
Copy link
Contributor

@mwjury mwjury commented Jan 19, 2021

Masking of data was added for grid points that have not been informed by station information and for which data is provided by statistic infilling of climatologic values. This results in additional cmorized output with version string version_grid-numgauge1 (e.g. v2018_25-numgauge1).

This pull request is an addition to #1982

Checklist

It is the responsibility of the author to make sure the PR is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated data reformatting script:

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers, we should be able to get this in v2.2 👍

@valeriupredoi
Copy link
Contributor

cheers @mwjury - I will merge once we merge the fix to the iris documentation from #2012 🍺

@valeriupredoi
Copy link
Contributor

friendly ping to @remi-kazeroni for a sci review 🍺

@remi-kazeroni
Copy link
Contributor

friendly ping to @remi-kazeroni for a sci review 🍺

Sure, I'm doing it now 👍

Copy link
Contributor

@remi-kazeroni remi-kazeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me. Data added to the OBS directory at DKRZ 👍

@valeriupredoi
Copy link
Contributor

shweet 🍺

@valeriupredoi valeriupredoi merged commit 9fc6959 into master Feb 17, 2021
@valeriupredoi valeriupredoi deleted the cmorize_gpcc_masking branch February 17, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants