Streamline observations download

.prospector.yml

@@ -10,24 +10,13 @@ test-warnings: true
 member-warnings: false
 
 pyroma:
-  run: true
+    run: true
 
 pep8:
-  full: true
+    full: true
 
 pep257:
-  # disable rules that are allowed by the numpy convention
-  # see https://github.com/PyCQA/pydocstyle/blob/master/src/pydocstyle/violations.py
-  # and http://pydocstyle.readthedocs.io/en/latest/error_codes.html
-  disable:
-    - D107
-    - D203
-    - D204
-    - D212
-    - D213
-    - D402
-    - D413
-    - D416
-
-pylint:
-  run: false
+    # disable rules that are allowed by the numpy convention
+    # see https://github.com/PyCQA/pydocstyle/blob/master/src/pydocstyle/violations.py
+    # and http://pydocstyle.readthedocs.io/en/latest/error_codes.html
+    disable: ['D107', 'D203', 'D212', 'D213', 'D402', 'D413', 'D416']

.pylintrc

@@ -65,59 +65,7 @@ confidence=
 # --enable=similarities". If you want to run only the classes checker, but have
 # no Warning level messages displayed, use"--disable=all --enable=classes
 # --disable=W"
-disable= apply-builtin,
-    backtick,
-    basestring-builtin,
-    buffer-builtin,
-    cmp-builtin,
-    cmp-method,
-    coerce-builtin,
-    coerce-method,
-    delslice-method,
-    dict-iter-method,
-    dict-view-method,
-    duplicate-code,
-    execfile-builtin,
-    file-builtin,
-    filter-builtin-not-iterating,
-    getslice-method,
-    hex-method,
-    import-error,
-    import-star-module-level,
-    indexing-exception,
-    input-builtin,
-    intern-builtin,
-    long-builtin,
-    long-suffix,
-    map-builtin-not-iterating,
-    metaclass-assignment,
-    next-method-called,
-    no-absolute-import,
-    nonzero-method,
-    oct-method,
-    old-division,
-    old-ne-operator,
-    old-octal-literal,
-    old-raise-syntax,
-    parameter-unpacking,
-    print-statement,
-    raising-string,
-    range-builtin-not-iterating,
-    raw_input-builtin,
-    reduce-builtin,
-    reload-builtin,
-    round-builtin,
-    setslice-method,
-    standarderror-builtin,
-    suppressed-message,
-    unichr-builtin,
-    unicode-builtin,
-    unpacking-in-except,
-    unused-argument,
-    useless-suppression,
-    using-cmp-argument,
-    xrange-builtin,
-    zip-builtin-not-iterating
+disable=import-star-module-level,old-octal-literal,oct-method,print-statement,unpacking-in-except,parameter-unpacking,backtick,old-raise-syntax,old-ne-operator,long-suffix,dict-view-method,dict-iter-method,metaclass-assignment,next-method-called,raising-string,indexing-exception,raw_input-builtin,long-builtin,file-builtin,execfile-builtin,coerce-builtin,cmp-builtin,buffer-builtin,basestring-builtin,apply-builtin,filter-builtin-not-iterating,using-cmp-argument,useless-suppression,range-builtin-not-iterating,suppressed-message,no-absolute-import,old-division,cmp-method,reload-builtin,zip-builtin-not-iterating,intern-builtin,unichr-builtin,reduce-builtin,standarderror-builtin,unicode-builtin,xrange-builtin,coerce-method,delslice-method,getslice-method,setslice-method,input-builtin,round-builtin,hex-method,nonzero-method,map-builtin-not-iterating,import-error
 
 
 [REPORTS]
@@ -372,7 +320,7 @@ ignore-imports=no
 [DESIGN]
 
 # Maximum number of arguments for function / method
-max-args=7
+max-args=5
 
 # Argument names that match this expression will be ignored. Default to name
 # with leading underscore

esmvaltool/cmorizers/data/cmorizer.py

@@ -535,6 +535,9 @@ def _parse_date(date):
             8: "%Y%m%d",
         }
         format_string = date_formats.get(len(date_string), None)
-        if format_string is None:
-            return None
+        if len(date_string) not in [4, 6, 8]:
+            raise ValueError(
+                f'Unsupported date format for {date}. '
+                'Supported formats for "start" and "end" are: '
+                '"None", "YYYY", "YYYYMM", "YYYYMMDD"')
         return datetime.datetime.strptime(date_string, format_string)