Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cmor_name instead of out_name #1493

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Use cmor_name instead of out_name #1493

wants to merge 9 commits into from

Conversation

jvegreg
Copy link
Contributor

@jvegreg jvegreg commented Jan 17, 2020

Companion branch to adapt to changes in ESMValGroup/ESMValCore#391

@mattiarighi
Copy link
Contributor

I fixed some short_name occurrences in the cmorizers for ERA-Interim and MERRA2, but it looks there are many more. @jvegasbsc can you please check?

  • cmorize_obs_cds_satellite_lai_fapar.py
  • cmorize_obs_cds_uerra.py
  • cmorize_obs_ceres_ebaf.py
  • cmorize_obs_cru.py
  • cmorize_obs_duveiller2018.py
  • cmorize_obs_eppley_vgpm_modis.py
  • cmorize_obs_esacci_oc.py
  • cmorize_obs_fluxcom.py
  • cmorize_obs_gcp.py
  • cmorize_obs_hwsd.py
  • cmorize_obs_jma_transcom.py
  • cmorize_obs_lai3g.py
  • cmorize_obs_landflux_eval.py
  • cmorize_obs_landschuetzer2016.py
  • cmorize_obs_mls_aura.py
  • cmorize_obs_mte.py
  • cmorize_obs_ndp.py
  • cmorize_obs_phc.py
  • cmorize_obs_piomas.py
  • cmorize_obs_woa.py
  • nsidc_common.py
  • osi_common.py
  • utilities.py

@mattiarighi
Copy link
Contributor

The affected recipes work fine.
There is an issue with recipe_anav13jclim which I'm reporting in #1548.

@zklaus
Copy link

zklaus commented Apr 3, 2020

@jvegasbsc quick question: The title is a typo, right? You are referring to short_name, not out_name which is the attribute in the json tables and will still be what we are using, right?

@bouweandela bouweandela added this to the v2.0.0 milestone Jun 8, 2020
@bouweandela
Copy link
Member

@jvegasbsc I added the v2.0.0 milestone because you were planning to support this feature for that milestone in the ESMValCore.

@mattiarighi
Copy link
Contributor

This needs to be merged in any case, otherwise the cmorizers might not work properly after ESMValGroup/ESMValCore#391

@bouweandela
Copy link
Member

Because the above linked ESMValCore pull request was not merged in time for the ESMValCore v2.0.0 release, this will go into the ESMValTool release after v2.0.0.

@jvegreg jvegreg requested a review from remi-kazeroni as a code owner May 4, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants