Development ocean scalar fields #1331
Open
+441
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abels in recipe and anomaly calculation.
…opment_ocean_scalar_fields
This was referenced Sep 24, 2019
tomaslovato
reviewed
Oct 17, 2019
There was a problem hiding this comment.
There are still some minor issues signaled by codacy report that could be improved.
Beside that it works for me.
As a general comment, there has been a proliferation of ocean recipes and scripts (that I also contributed) and it will likely be necessary to do some rationalization after the finalization of this PR.
What do you think?
bouweandela
reviewed
Nov 1, 2019
| @@ -47,7 +48,299 @@ diagnostics: | |||
| variables: | |||
| mfo: # sea_water_transport_across_line | |||
| mip: Omon | |||
| preprocessor: prep_timeseries_drake | |||
| additional_datasets: | |||
| - {dataset: ACCESS1-0, project: CMIP5, exp: historical, ensemble: r1i1p1, start_year: 1900, end_year: 2004} | |||
There was a problem hiding this comment.
You might want to consider adding the dataset keys that are the same for all datasets (it looks like that is everything but the dataset name?) as keys under the variable, that would really increase readability.
This was referenced Aug 3, 2020
|
@ledm, is this something we should/could address during the November Workshop? |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some additional features into the time series plots, notably the ability to calculate an anomaly, and to specify plot titles and axes labels in the recipe.
Also, I've added several new data fields into the
recipe_ocean_scalar_fields.ymlrecipe. Several of these figures are being submitted in part 2 of the paper, so I hope that we can get this PR accepted before that paper gets too far along the way,This is linked with issue #1166.