Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkbox in PR template to assign labels #985

Merged
merged 3 commits into from
Feb 8, 2021

Conversation

jvegreg
Copy link
Contributor

@jvegreg jvegreg commented Feb 5, 2021

As we use them in the changelog, they are a must in every PR

Before you get started

Checklist

If you make backwards incompatible changes to the recipe format:

  • Update ESMValTool and link the pull request(s) in the description

To help with the number pull requests:

@jvegreg jvegreg added the documentation Improvements or additions to documentation label Feb 5, 2021
@stefsmeets
Copy link
Contributor

stefsmeets commented Feb 5, 2021

Hi @jvegasbsc Could you add some documentation (contributing guidelines) on how to assign labels and what labels should be assigned, and link to it from the PR template like we do with the other items?

Copy link
Contributor

@stefsmeets stefsmeets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Looks good to me! 👍

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers @jvegasbsc 🍺

@valeriupredoi valeriupredoi merged commit 0f50036 into master Feb 8, 2021
@valeriupredoi valeriupredoi deleted the update_pull_request_template branch February 8, 2021 11:59
jvegreg pushed a commit that referenced this pull request Feb 9, 2021
* Add checkbox in PR template to assign labels

* Updated doc

Co-authored-by: Valeriu Predoi <valeriu.predoi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants