Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set version to 2.2.0 #977

Merged
merged 5 commits into from
Feb 2, 2021
Merged

Set version to 2.2.0 #977

merged 5 commits into from
Feb 2, 2021

Conversation

jvegreg
Copy link
Contributor

@jvegreg jvegreg commented Feb 1, 2021

Just what it says

Checklist

If you make backwards incompatible changes to the recipe format:

  • Update ESMValTool and link the pull request(s) in the description

To help with the number pull requests:

@jvegreg jvegreg self-assigned this Feb 1, 2021
@jvegreg jvegreg added this to the v2.2.0 milestone Feb 1, 2021
@valeriupredoi
Copy link
Contributor

valeriupredoi commented Feb 1, 2021

good one @jvegasbsc - we're on the road again 😁 A few things:

  • after we merge this, we need the release branch - ask @mattiarighi to set no-push/no-merge permissions on that - or you have these prerogatives already, if you do pls set them on that branch, just you and me can work on it; then we'll ask peeps to run recipes; we should also make sure that you have the pypi and anaconda credentials to upload the packages via automatic Github Actions - maybe we can chat over a call soon about all this jazz?

For here:

  • you'll have to change the version in esmvalcore/_version.py and in package/meta.yaml too
  • you'll have to change the date-released: 2020-10-12 in CITATION.cff too

🍺

@jvegreg
Copy link
Contributor Author

jvegreg commented Feb 1, 2021

Yes, tomorrow morning it's ok? I can not set an hour now, but will contact you in the morning

@valeriupredoi
Copy link
Contributor

valeriupredoi commented Feb 1, 2021

sounds good, my morning starts at 11am your time, so no rush 😁 I'll set up a zoom call for us

@jvegreg
Copy link
Contributor Author

jvegreg commented Feb 2, 2021

I updated the zenodo link to version 2.1, so at least it does not point to a beta release and set up the release date to next monday. We may need to update it, but its a better approximation just in case we forget.

By the way, I love this unique identifier loop: I need to do the release to get the number but I would like to have the number in the release metadata

Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you find the instructions we have available for making a release? They live here: https://docs.esmvaltool.org/projects/esmvalcore/en/latest/contributing.html#how-to-make-a-release

One of the things mentioned there is the list of files in which the version number lives. It looks like you forgot to update package/meta.yaml, could you update the version number in that file too?

@valeriupredoi
Copy link
Contributor

let's have a list of things that we want merged in the release branch before release #982

@valeriupredoi
Copy link
Contributor

this is beautiful:
buffg

@jvegreg jvegreg merged commit 0ce497c into master Feb 2, 2021
@jvegreg jvegreg deleted the Bump-version branch February 2, 2021 21:04
@jvegreg jvegreg added the documentation Improvements or additions to documentation label Feb 3, 2021
@schlunma schlunma mentioned this pull request Feb 3, 2021
jvegreg pushed a commit that referenced this pull request Feb 9, 2021
* Set version to 2.2.0

* Update CITATION.cff

* Update CITATION.cff

* Update meta.yaml version number

* Use generix zenodo doi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants