Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to run single diagnostic task to notebook API #962

Merged
merged 10 commits into from
Jan 29, 2021

Conversation

stefsmeets
Copy link
Contributor

@stefsmeets stefsmeets commented Jan 26, 2021

Description

Hi everyone, this PR extends the API to run recipes in an interactive notebook.

It adds functionality to list and run a single diagnostic task, and display/load the output directly in the notebook. I also cleaned up some long references in the API documentation.


Before you get started

Checklist


To help with the number pull requests:

@stefsmeets stefsmeets changed the title Add functionality to run single diagnostic task Add functionality to run single diagnostic task to notebook API Jan 26, 2021
@stefsmeets stefsmeets requested a review from Peter9192 January 27, 2021 13:45
@stefsmeets stefsmeets marked this pull request as ready for review January 27, 2021 13:45
@stefsmeets
Copy link
Contributor Author

Hi @Peter9192 , it turned out to be more or less 1 line of code after all 😅 Could you have a look and let me know what you think?

Copy link
Contributor

@Peter9192 Peter9192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works super smooth! Nice job :-)
One question about the docs formatting and one typo I think.

Co-authored-by: Peter Kalverla <peter.kalverla@gmx.com>
@stefsmeets
Copy link
Contributor Author

Thanks @Peter9192 !

This is now ready to be merged! @nielsdrost @bouweandela

@nielsdrost nielsdrost merged commit cc5283d into master Jan 29, 2021
@nielsdrost nielsdrost deleted the api_run_diagnostic2 branch January 29, 2021 12:46
@nielsdrost
Copy link
Member

Thanks @Peter9192 and @stefsmeets!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Notebook API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants