Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin scipy to less than 1.6.0 until ESMValGroup/ESMValCore/issues/927 gets resolved #928

Merged
merged 3 commits into from
Jan 7, 2021

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Jan 6, 2021

Description


Before you get started

Checklist

If you make backwards incompatible changes to the recipe format:

  • Update ESMValTool and link the pull request(s) in the description

To help with the number pull requests:

@bouweandela
Copy link
Member

You'll also need to update setup.py

Copy link
Contributor

@jvegreg jvegreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, V! I think is pretty safe to do this as we are already working on solving #927

@valeriupredoi
Copy link
Contributor Author

You'll also need to update setup.py

no because scipy gets installed from conda-forge

@valeriupredoi
Copy link
Contributor Author

Thanks, V! I think is pretty safe to do this as we are already working on solving #927

cool, cheers Javi! @bouweandela I am merging this since setup.py doesn't need to be changed 👍

@valeriupredoi valeriupredoi merged commit ce5fee1 into master Jan 7, 2021
@valeriupredoi valeriupredoi deleted the pin_scipy branch January 7, 2021 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation Installation problem testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants