Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding custom variables for tas uncertainty #924

Merged
merged 5 commits into from
Jan 5, 2021
Merged

Adding custom variables for tas uncertainty #924

merged 5 commits into from
Jan 5, 2021

Conversation

LisaBock
Copy link
Contributor

@LisaBock LisaBock commented Jan 4, 2021

Description

Adding custom varaibles for uncertainty of tas

tasConf5: range of uncertainty to lower bound (5% qunatile)
tasConf95: range of uncertainty to upper bound (95% quantile)


Before you get started

Checklist

@LisaBock LisaBock requested a review from jvegreg as a code owner January 4, 2021 16:18
@LisaBock LisaBock changed the title Bock20jgr Addin custom vars for uncertainty Jan 4, 2021
@LisaBock LisaBock changed the title Addin custom vars for uncertainty Adding custom variables for tas uncertainty Jan 4, 2021
@jvegreg jvegreg self-assigned this Jan 5, 2021
@jvegreg jvegreg added the cmor Related to the CMOR standard label Jan 5, 2021
@jvegreg
Copy link
Contributor

jvegreg commented Jan 5, 2021

Nice! I added a couple tests to check that they are handled correctly. We do not have equivalent tests for other custom vars, but it is the easiest way to test this

@jvegreg jvegreg merged commit 919efa9 into master Jan 5, 2021
@jvegreg jvegreg deleted the bock20jgr branch January 5, 2021 10:29
@LisaBock
Copy link
Contributor Author

LisaBock commented Jan 5, 2021

Nice! I added a couple tests to check that they are handled correctly. We do not have equivalent tests for other custom vars, but it is the easiest way to test this

@jvegasbsc Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmor Related to the CMOR standard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding uncertainty variables for tas
2 participants