-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xco2 derivation #913
xco2 derivation #913
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise, it looks great. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice plots&code @bettina-gier - could you pls ping @hb326 or @axel-lauer or whoever else you reckon as appropriate for a sci review? 🍺
Both of them work, I just don't know if they're back from christmas vacation - but consider them pinged with your message ;) |
@bettina-gier: I found some "ch4" reference remnants in the code, of which I am not sure if they should still be in there or if they are just leftovers from the xch4 derivation code that you used as a guideline for the xco2 code. |
You're right they're leftovers, thanks for spotting these! Maybe I should have just used find and replace =D |
Not sure why there is now a check failing... |
Seems to be an era5 thing that is failing now: =========================== short test summary info ============================ |
it's the hardcoded 2020 crap year in era5 that has been fixed upstream 👍 |
Before you start, please read our contribution guidelines.
Tasks
If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.
Closes #912
Now that XCH4 is merged, let's add XCO2!
Sample recipe with some data available on mistral:
Using some additional fixes, and other models, as well as diagnostics from an open pull request for a comparison:
