Fix overwriting in generic level check #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
@sloosvel and @schlunma yous are legends, cheers for the quick turnaround. Saskia, let me know when you ready with the suggestion from Manuel and I can merge - I think this is a very nice fix and I would like to include this in the bugfix release that @bouweandela and myself will do tomorrow so it'd be nice if you addressed Manu's suggestion pronto-pronto 😁 |
Co-authored-by: Manuel Schlund <32543114+schlunma@users.noreply.github.com>
|
@valeriupredoi There is no need to rush this, as the bug is not in a released version. |
|
ah right you are @bouweandela - I was under the impression we've released it already - ok, then we can wait, sorry for hurrying you @sloosvel 😀 |
schlunma
approved these changes
Dec 1, 2020
bouweandela
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before you start, please read our contribution guidelines.
Tasks
If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.
The previous implementation was working directly with the dict containing the CMOR information. This led to accidental overwritting of the dict values in some runs and ended up causing incorrect reporting of errors. Tested with several datasets and variables and it seems that this issue does not happen anymore, but should be double checked of course.
Closes #883