Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and publish the esmvalcore package to conda via Github Actions workflow #825

Merged
merged 10 commits into from
Oct 12, 2020

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Oct 12, 2020

This builds and publishes the esmvalcore package to conda - currently untested; the conda build alone step is done via PR #818 so should work OK but the publishing is brand new territory for me. @bouweandela and @fdiblen could you guys have a look please. @fdiblen cheers for the pointer to the test GA workflow you have, I used that one! 🍺 BTW the base branch is release_2.1 so we can easily merge this in the release branch if you guys think it's okay 👍

schlunma and others added 2 commits October 9, 2020 15:30
* Added check for units at the end of derivation function

* Fixed tests for variable derivation interface

* Adapted several derivation scripts

* Adapted sm derivation script for CMIP6

* Fixed derivation of vegfrac and ohc

* Fixed CMOR checker when coordinate standard_name is empty
Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start! Could you merge master into this branch, so the diff on GitHub shows which files are actually changed?

@valeriupredoi
Copy link
Contributor Author

valeriupredoi commented Oct 12, 2020

we have liftoff of the Conda Package space shuttle 🚀 ie all works fine in test mode see GA tests

Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@valeriupredoi valeriupredoi merged commit 5ef3833 into master Oct 12, 2020
@valeriupredoi valeriupredoi deleted the conda_publish_GA branch October 12, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants