Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CODEOWNERS file #809

Merged
merged 2 commits into from
Oct 26, 2020
Merged

Create CODEOWNERS file #809

merged 2 commits into from
Oct 26, 2020

Conversation

jvegreg
Copy link
Contributor

@jvegreg jvegreg commented Oct 2, 2020

As discussed in ESMValGroup/ESMValTool#968

I started by adding me as owner of all the CMOR related stuff so I do not miss any changes to it.

Feel free to add your own entries.

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • This pull request has a descriptive title that can be used in a changelog
  • Add unit tests
  • Public functions should have a numpy-style docstring so they appear properly in the API documentation. For all other functions a one line docstring is sufficient.
  • If writing a new/modified preprocessor function, please update the documentation
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Codacy code quality checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes
  • If you make backward incompatible changes to the recipe format, make a new pull request in the ESMValTool repository and add the link below

@jvegreg jvegreg requested review from zklaus and bouweandela October 2, 2020 13:47
@jvegreg jvegreg merged commit b7ddbea into master Oct 26, 2020
@jvegreg jvegreg deleted the add_codeowners branch October 26, 2020 10:20
@jvegreg jvegreg added the enhancement New feature or request label Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants