Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readable exclude pattern for pre-commit #770

Merged
merged 1 commit into from
Sep 7, 2020

Conversation

stefsmeets
Copy link
Contributor

@stefsmeets stefsmeets commented Sep 7, 2020

Small tweak to make the excluded files span multiple lines, as in ESMValGroup/ESMValTool#1805 . It makes the regex a bit more robust, looks nicer, and will make it a bit easier to add/remove new directories to the exclude list if necessary.

Tasks

  • This pull request has a descriptive title that can be used in a changelog
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Codacy code quality checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


@stefsmeets stefsmeets marked this pull request as ready for review September 7, 2020 08:46
@bouweandela bouweandela changed the title .pre-commit-config.yaml regex tweak Readable exclude pattern for pre-commit Sep 7, 2020
@bouweandela bouweandela merged commit 505db58 into master Sep 7, 2020
@bouweandela bouweandela deleted the pre-commit-config-patch branch September 7, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants