-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CMIP6 tables to 6.9.32 #706
Conversation
* Fixed calculation of time weights * Fixed failing FLAKE8 test * Added more test for time weighting and fixed cube dimensions in test
The tests are failing because of an error of pytest. They run locally without issue |
Thanks! I created a pull request to fix the failing tests: #707. |
Codacy analysis was not setup for this branch. I just did it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! @mattiarighi Could you please test?
I think we can test this once we make the final run of all recipes. |
Just for clarity, do we want to have this included in v2.0.0? We've had problems in the past when updating the CMOR tables, because the format changed, so I'm not sure if it's safe to include an update this late. |
My answer will be yes, but not as much as to block v2.0 release. I think we can manage to do it, as it will be tested thoroughly when running all the recipes. Also, if we detect non trivial issues, reverting this change is easy and safe, as no other commits will modify the affected files. |
The main question then is, when are we going to do this? After the ESMValCore v2.0.0 release on July 20 or before it? I have tried to run about 20 recipes on the esmvaltool VM, but have no time to continue that testing before the release. @mattiarighi What are your plans in this? |
Ideally all recipes should work with the released version. Concerning the tables, it's probably better to include this at a later stage. |
Ok, just beware that some model names have changed between versions. It is possible that you find errors because of this in CMIP6 recipes if the data in DKRZ has been updated |
Merging this now, so it will be included in the next release. |
As request by @bouweandela in #704
Tasks
yamllint
to check that your YAML files do not contain mistakesIf you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.
Closes #704