Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix siconca variable in EC-Earth3 and EC-Earth3-Veg models in amip simulation #702

Merged
merged 8 commits into from
Oct 2, 2020

Conversation

egalytska
Copy link
Contributor

@egalytska egalytska commented Jul 8, 2020

Before you start, please read our contribution guidelines.

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • This pull request has a descriptive title that can be used in a changelog
  • Add unit tests
  • Public functions should have a numpy-style docstring so they appear properly in the API documentation. For all other functions a one line docstring is sufficient.
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Codacy code quality checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


Closes #703

@egalytska egalytska requested a review from axel-lauer July 8, 2020 11:28
@egalytska egalytska added the fix for dataset Related to dataset-specific fix files label Jul 8, 2020
@egalytska
Copy link
Contributor Author

egalytska commented Aug 14, 2020

@valeriupredoi could you please have a look at new changes that include a suggestion of @bouweandela
Btw, Codacy is still complaining =/

@valeriupredoi
Copy link
Contributor

@egalytska - done and I added two tests for your fixes. I think this is ready to go 👍

@bouweandela bouweandela merged commit 71d4893 into master Oct 2, 2020
@bouweandela bouweandela deleted the fix_EC-Earth_models_amip_siconca branch October 2, 2020 07:36
@egalytska
Copy link
Contributor Author

@egalytska - done and I added two tests for your fixes. I think this is ready to go

@valeriupredoi Thanks a lot!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix for dataset Related to dataset-specific fix files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with siconca variable in EC-Earth-Consortium models in CMIP6 amip simulation
3 participants