Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.py and README.md for use on PyPI #693

Merged
merged 2 commits into from
Jul 2, 2020
Merged

Update setup.py and README.md for use on PyPI #693

merged 2 commits into from
Jul 2, 2020

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Jul 2, 2020

Update setup.py and README.md so we can publish the ESMValCore package on PyPI. See here for more information.

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • This pull request has a descriptive title that can be used in a changelog
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Codacy code quality checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.

Needed for #84

@bouweandela bouweandela requested a review from mattiarighi July 2, 2020 12:32
@bouweandela bouweandela marked this pull request as ready for review July 2, 2020 12:32
@bouweandela bouweandela added documentation Improvements or additions to documentation installation Installation problem labels Jul 2, 2020
@bouweandela
Copy link
Member Author

The package can be tested by running:

conda env create -n test -f environment.yml
conda activate test
pip install fire fiona nc-time-axis numba prov[dot] yamale
pip install --index-url https://test.pypi.org/simple/ --no-deps esmvalcore

This will first install all dependencies using Conda or PyPI and then the esmvalcore package from the test version of PyPI: https://test.pypi.org/project/ESMValCore/

To build and upload the package I followed the instructions here and used the commands

python setup.py sdist bdist_wheel
python -m twine upload --repository testpypi dist/*

@bouweandela bouweandela merged commit df98aa0 into master Jul 2, 2020
@bouweandela bouweandela deleted the pypi branch July 2, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation installation Installation problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants