Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin flake8 #646

Merged
merged 1 commit into from
May 19, 2020
Merged

Unpin flake8 #646

merged 1 commit into from
May 19, 2020

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented May 19, 2020 •
edited
Loading

Unpin flake8, so we can use the latest version.

Tasks

  • This pull request has a descriptive title that can be used in a changelog
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Codacy code quality checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.

@valeriupredoi
Copy link
Contributor

back to flaking around I see 😁

@bouweandela bouweandela marked this pull request as ready for review May 19, 2020 11:33
@bouweandela bouweandela requested a review from valeriupredoi May 19, 2020 11:33
valeriupredoi
valeriupredoi approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

env solves and builds, tests pass with flying colours, cheers @bouweandela

@bouweandela bouweandela merged commit d364515 into master May 19, 2020
@bouweandela bouweandela deleted the update-pytest-flake8 branch May 19, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valeriupredoi valeriupredoi valeriupredoi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bouweandela @valeriupredoi