Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fix to convert "geopotential" to "geopotential height" for ERA5 #640

Merged
merged 2 commits into from
May 19, 2020

Conversation

egalytska
Copy link
Contributor

@egalytska egalytska commented May 18, 2020

Before you start, please read CONTRIBUTING.md.

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • This pull request has a descriptive title that can be used in a changelog
  • Add unit tests
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Codacy code quality checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


This pull request is related to ESMValTool pull request ESMValGroup/ESMValTool#1644.

@egalytska egalytska requested a review from bouweandela May 18, 2020 11:37
@bouweandela bouweandela changed the title edited era5 cmor fixes to calculate geopotential height Added fix to convert "geopotential" to "geopotential height" for ERA5 May 18, 2020
@bouweandela bouweandela added the fix for dataset Related to dataset-specific fix files label May 18, 2020
@bouweandela bouweandela requested a review from valeriupredoi May 18, 2020 13:46
@bouweandela
Copy link
Member

bouweandela commented May 18, 2020

@valeriupredoi Would you be able to test this and help with adding a unit test?

@valeriupredoi
Copy link
Contributor

I will add a unit test in a jiffy but can't test since we don't have any ERA5 data on Jasmin - @mattiarighi is the ERA5 landlord at DKRZ 😁

@bouweandela
Copy link
Member

bouweandela commented May 19, 2020

I will add a unit test in a jiffy but can't test since we don't have any ERA5 data on Jasmin

@valeriupredoi Here is a blog post announcing the availability of ERA5 on Jasmin. It is stored in /badc/ecmwf-era5 and /badc/ecmwf-era5t

@mattiarighi mattiarighi merged commit 310bb57 into master May 19, 2020
@mattiarighi mattiarighi deleted the update_era5_cmor_fixes branch May 19, 2020 11:50
@valeriupredoi
Copy link
Contributor

dam right you are it's there, had no idea! But am gonna need a manual to be able to understand what's the data paths - do we have this location anywhere in the documentation and some instructions on how to grab files depending what one needs?

@bouweandela
Copy link
Member

There is some documentation here: https://confluence.ecmwf.int/display/CKB/ERA5%3A+data+documentation#ERA5:datadocumentation-DataorganisationandhowtodownloadERA5, click Data organisation in MARS to expand the tab to have an explanation of the facets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix for dataset Related to dataset-specific fix files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants