Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max, min and std operators to multimodel #602

Merged
merged 3 commits into from
May 18, 2020

Conversation

jvegreg
Copy link
Contributor

@jvegreg jvegreg commented Apr 1, 2020

Added several operators to the multimodel, as requested by @mwjury

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • This pull request has a descriptive title that can be used in a changelog
  • Add unit tests
  • Public functions should have a numpy-style docstring so they appear properly in the API documentation. For all other functions a one line docstring is sufficient.
  • If writing a new/modified preprocessor function, please update the documentation
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Codacy code quality checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes
  • If you make backward incompatible changes to the recipe format, make a new pull request in the ESMValTool repository and add the link below

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


Closes #563

@jvegreg jvegreg added enhancement New feature or request preprocessor Related to the preprocessor labels Apr 1, 2020
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers Javi @jvegasbsc - I was supposed to do this but it completely slipped my mind 🍺 It's worth pointing out and I think we need to add it to the documentation that these are local (min, max) and not global

@jvegreg
Copy link
Contributor Author

jvegreg commented Apr 1, 2020

If we add a comment about it, we should do it for every operator. All are local

@valeriupredoi
Copy link
Contributor

yeah I think we should say that, lemme add it to the doc

Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! @mattiarighi Could you please test?

@mattiarighi
Copy link
Contributor

I have some installation issues at the moment (see #535) and cannot test.

@bouweandela
Copy link
Member

@mattiarighi Did you manage to solve your installation issues?

@mattiarighi
Copy link
Contributor

Yes, sorry for being absent lately, I'm very busy with other projects.
I'll try to test this and the other PRs this week.

@mattiarighi
Copy link
Contributor

Seems to work as expected, thanks for adding this feature!

@mattiarighi mattiarighi merged commit dd596d3 into master May 18, 2020
@mattiarighi mattiarighi deleted the add_operators_to_multimodel branch May 18, 2020 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request preprocessor Related to the preprocessor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multi model statistics -- more statistics
4 participants