Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log warnings for likely errors in provenance record #592

Merged
merged 4 commits into from
May 18, 2020
Merged

Log warnings for likely errors in provenance record #592

merged 4 commits into from
May 18, 2020

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Mar 30, 2020 •
edited
Loading

Before you start, please read CONTRIBUTING.md.

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • This pull request has a descriptive title that can be used in a changelog
  • Add unit tests
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Codacy code quality checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.

Related to issue #124

@bouweandela bouweandela force-pushed the warn-wrong-provenance branch from 7cabf46 to e65fd84 Compare May 18, 2020 09:20
@bouweandela bouweandela marked this pull request as ready for review May 18, 2020 13:55
valeriupredoi
valeriupredoi approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go for it! nice one 🍺

@bouweandela bouweandela merged commit bb9dcc7 into master May 18, 2020
@bouweandela bouweandela deleted the warn-wrong-provenance branch May 18, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattiarighi mattiarighi mattiarighi approved these changes

@valeriupredoi valeriupredoi valeriupredoi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bouweandela @mattiarighi @valeriupredoi