Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapted custom co2s table to match CMIP6 version #588

Merged
merged 3 commits into from
Mar 27, 2020
Merged

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Mar 26, 2020

This PR fixes the custom co2s table to match its CMIP6 version as discussed in #587.

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • This pull request has a descriptive title that can be used in a changelog
  • Add unit tests
  • Public functions should have a numpy-style docstring so they appear properly in the API documentation. For all other functions a one line docstring is sufficient.
  • If writing a new/modified preprocessor function, please update the documentation
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Codacy code quality checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes
  • If you make backward incompatible changes to the recipe format, make a new pull request in the ESMValTool repository and add the link below

@schlunma schlunma added the cmor Related to the CMOR standard label Mar 26, 2020
@schlunma schlunma requested a review from mattiarighi March 26, 2020 09:30
@schlunma schlunma self-assigned this Mar 26, 2020
@mattiarighi
Copy link
Contributor

The tests are failing, but it looks like an internal circleci error.

@schlunma
Copy link
Contributor Author

I think so too, can we restart the test somehow?

@mattiarighi
Copy link
Contributor

There is a restart button, but I have no rights to trigger a restart.

@schlunma
Copy link
Contributor Author

Tests are fine now

@mattiarighi mattiarighi merged commit c851053 into master Mar 27, 2020
@mattiarighi mattiarighi deleted the fix_co2s_table branch March 27, 2020 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmor Related to the CMOR standard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants