Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SYNDA drs for CMIP5 and CMIP6 (closes #582) #583

Merged
merged 4 commits into from
Jun 7, 2021
Merged

Add SYNDA drs for CMIP5 and CMIP6 (closes #582) #583

merged 4 commits into from
Jun 7, 2021

Conversation

zklaus
Copy link

@zklaus zklaus commented Mar 23, 2020

Before you start, please read CONTRIBUTING.md.

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • This pull request has a descriptive title that can be used in a changelog
    - Add unit tests
  • Public functions should have a numpy-style docstring so they appear properly in the API documentation. For all other functions a one line docstring is sufficient.
  • please update the documentation
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Codacy code quality checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes
  • If you make backward incompatible changes to the recipe format, make a new pull request in the ESMValTool repository and add the link below

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


Closes #582

Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the paths that synda creates appear to be configurable: http://prodiguer.github.io/synda/sdt/selection_file_param_ref.html#synda-formatting-parameters
I guess this would be the default directory structure?

Maybe it would also be nice to add a note about this in the documentation somewhere? We have two relevant sections, https://esmvaltool.readthedocs.io/en/latest/input.html and https://esmvaltool.readthedocs.io/projects/esmvalcore/en/latest/quickstart/find_data.html.

@zklaus
Copy link
Author

zklaus commented Mar 25, 2020

Yes, this is the default structure. Note also that the configuration that you link to above is per selection file. This is not the only, perhaps not even the most common way to download using the daemon.

I'll see about the documentation.

@valeriupredoi
Copy link
Contributor

@bouweandela yes - K-man is right since we are using synda get in our module which is the basic no-checks command that gets the files noqa 🍺

@stefsmeets
Copy link
Contributor

stefsmeets commented May 28, 2021

Hi @ESMValGroup/esmvaltool-coreteam , seems like this PR has been sitting around approved and ready to go for a while 😅 It's a two line fix, can this just be merged?

@bouweandela
Copy link
Member

No, the documentation has still not been added.

@stefsmeets
Copy link
Contributor

No, the documentation has still not been added.

Thanks @bouweandela , I added a short paragraph to the esmvalcore documentation 👍
https://esmvaltool--583.org.readthedocs.build/projects/ESMValCore/en/583/quickstart/find_data.html#synda

@stefsmeets stefsmeets requested a review from bouweandela May 28, 2021 09:07
Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stefsmeets for wrapping this up!

@bouweandela bouweandela added this to the v2.3.0 milestone May 28, 2021
@zklaus zklaus merged commit d22bd4a into main Jun 7, 2021
@zklaus zklaus deleted the synda-drs branch June 7, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SYNDA drs
5 participants