-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SYNDA drs for CMIP5 and CMIP6 (closes #582) #583
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the paths that synda creates appear to be configurable: http://prodiguer.github.io/synda/sdt/selection_file_param_ref.html#synda-formatting-parameters
I guess this would be the default directory structure?
Maybe it would also be nice to add a note about this in the documentation somewhere? We have two relevant sections, https://esmvaltool.readthedocs.io/en/latest/input.html and https://esmvaltool.readthedocs.io/projects/esmvalcore/en/latest/quickstart/find_data.html.
Yes, this is the default structure. Note also that the configuration that you link to above is per selection file. This is not the only, perhaps not even the most common way to download using the daemon. I'll see about the documentation. |
@bouweandela yes - K-man is right since we are using |
Hi @ESMValGroup/esmvaltool-coreteam , seems like this PR has been sitting around approved and ready to go for a while 😅 It's a two line fix, can this just be merged? |
No, the documentation has still not been added. |
Thanks @bouweandela , I added a short paragraph to the esmvalcore documentation 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stefsmeets for wrapping this up!
Before you start, please read CONTRIBUTING.md.
Tasks
- Add unit testsyamllint
to check that your YAML files do not contain mistakesIf you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.
Closes #582