Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mask in land variables for CCSM4 (fixes #578) #579

Merged
merged 3 commits into from
Mar 23, 2020
Merged

Conversation

zklaus
Copy link

@zklaus zklaus commented Mar 20, 2020

Before you start, please read CONTRIBUTING.md.

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • This pull request has a descriptive title that can be used in a changelog
  • Add unit tests
  • Public functions should have a numpy-style docstring so they appear properly in the API documentation. For all other functions a one line docstring is sufficient.
  • If writing a new/modified preprocessor function, please update the documentation
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Codacy code quality checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes
  • If you make backward incompatible changes to the recipe format, make a new pull request in the ESMValTool repository and add the link below

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


Closes #578

@zklaus zklaus requested a review from schlunma March 20, 2020 16:22
Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, didn't test though. If you provide a small recipe I can run a quick test on DKRZ if you like.

@schlunma schlunma self-requested a review March 23, 2020 12:49
Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully tested on DKRZ, plots look okay (there is a weird line at lon=0, but I guess that is not related to this PR).

diag_CMIP5_CCSM4_Lmon_historical_r1i1p1_gpp_prep_map_1_map_gpp_2001_2004_map_0

@mattiarighi mattiarighi merged commit 9b7cbb3 into master Mar 23, 2020
@mattiarighi mattiarighi deleted the fix_ccsm4_mask branch March 23, 2020 12:55
@zklaus
Copy link
Author

zklaus commented Mar 23, 2020

Cheers 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataset problem: bad masking on Lmon variables for CCSM4 (CMIP5)
3 participants