Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pointers about data loading and CF standards to documentation #571

Merged
merged 2 commits into from
May 18, 2020

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Mar 12, 2020

Before you start, please read CONTRIBUTING.md.

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • This pull request has a descriptive title that can be used in a changelog
  • Add unit tests
  • Public functions should have a numpy-style docstring so they appear properly in the API documentation. For all other functions a one line docstring is sufficient.
  • If writing a new/modified preprocessor function, please update the documentation
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Codacy code quality checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes
  • If you make backward incompatible changes to the recipe format, make a new pull request in the ESMValTool repository and add the link below

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


Closes {Link to corresponding issue}

@valeriupredoi valeriupredoi added the documentation Improvements or additions to documentation label Mar 12, 2020
@valeriupredoi
Copy link
Contributor Author

cheers @mattiarighi - @ledm @zklaus you guys wanna add more stuffs? I'll merge if nay 🍺

@bouweandela bouweandela changed the title added useful pointers about data loading and CF standards Add pointers about data loading and CF standards to documentation May 18, 2020
@bouweandela
Copy link
Member

Looks good to me! @valeriupredoi Could you fix the merge conflict?

@valeriupredoi valeriupredoi merged commit cac2f35 into master May 18, 2020
@valeriupredoi valeriupredoi deleted the load_documentation branch May 18, 2020 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants