Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated preprocessor function cleanup #2215

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Oct 2, 2023

Description

Remove deprecated preprocessor function cleanup. No upgrade action is available or required from users.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #2215 (d2183e6) into main (837ce35) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2215      +/-   ##
==========================================
- Coverage   93.21%   93.21%   -0.01%     
==========================================
  Files         238      238              
  Lines       12851    12835      -16     
==========================================
- Hits        11979    11964      -15     
+ Misses        872      871       -1     
Files Coverage Δ
esmvalcore/preprocessor/__init__.py 95.23% <ø> (-0.04%) ⬇️
esmvalcore/preprocessor/_io.py 86.44% <ø> (-0.36%) ⬇️

@bouweandela bouweandela added this to the v2.10.0 milestone Oct 2, 2023
@bouweandela bouweandela marked this pull request as ready for review October 2, 2023 10:20
Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment 👍

Co-authored-by: Manuel Schlund <32543114+schlunma@users.noreply.github.com>
@valeriupredoi
Copy link
Contributor

cheers, fellas 🍺

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to squeakybumtime - it's not used anywhere in Tool

@valeriupredoi valeriupredoi merged commit bd3b9a4 into main Oct 4, 2023
@valeriupredoi valeriupredoi deleted the remove-cleanup-preprocessor branch October 4, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants