Removed deprecated configuration option offline
#2213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2213 +/- ##
==========================================
- Coverage 93.21% 93.19% -0.03%
==========================================
Files 238 238
Lines 12851 12840 -11
==========================================
- Hits 11979 11966 -13
- Misses 872 874 +2
|
bouweandela
requested changes
Oct 2, 2023
There was a problem hiding this comment.
There is a bit of code left in esmvalcore/_main.py that is also part of this feature, could you have a look?
https://github.com/ESMValGroup/ESMValCore/blob/remove_offline/esmvalcore/_main.py#L368-L376
|
Whoopsie, looks like I messed up the |
bouweandela
approved these changes
Oct 2, 2023
|
It looks like the feature is also used in the backward compatibility tests: https://github.com/ESMValGroup/ESMValTool/blob/main/.circleci/config.yml#L217 |
|
Good catch, see ESMValGroup/ESMValTool#3367. |
valeriupredoi
approved these changes
Oct 4, 2023
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the deprecated configuration option
offline.Detailed upgrade instructions: #1935
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
Changes are backward compatibleTo help with the number pull requests: