Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated callback argument from preprocessor load function #2207

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Sep 26, 2023

Description

Remove the deprecated argument callback from the preprocessor function load.

Upgrade instructions: use esmvalcore.dataset.Dataset.load() instead.

Closes #1800


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #2207 (fded02d) into main (a6f257a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2207      +/-   ##
==========================================
- Coverage   93.14%   93.14%   -0.01%     
==========================================
  Files         237      237              
  Lines       12841    12831      -10     
==========================================
- Hits        11961    11951      -10     
  Misses        880      880              
Files Coverage Δ
esmvalcore/_recipe/recipe.py 99.01% <ø> (-0.01%) ⬇️
esmvalcore/dataset.py 100.00% <100.00%> (ø)
esmvalcore/preprocessor/__init__.py 95.22% <100.00%> (-0.02%) ⬇️
esmvalcore/preprocessor/_io.py 86.80% <100.00%> (-0.31%) ⬇️

@bouweandela bouweandela mentioned this pull request Sep 26, 2023
10 tasks
@bouweandela bouweandela added this to the v2.10.0 milestone Sep 26, 2023
@bouweandela bouweandela marked this pull request as ready for review September 26, 2023 20:14
Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bouwe, everything looks good to me. I successfully ran some example recipes with this 👍

@bouweandela bouweandela added the preprocessor Related to the preprocessor label Sep 28, 2023
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cheers 🍺

@valeriupredoi valeriupredoi merged commit c62ddc6 into main Sep 28, 2023
@valeriupredoi valeriupredoi deleted the remove-deprecated-callback-arg branch September 28, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal to deprecate the callback argument from esmvalcore.preprocessor.load in v2.8 and remove it in v2.10.
3 participants