Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove coord discontinuity check in regrid #2119

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

sloosvel
Copy link
Contributor

@sloosvel sloosvel commented Jun 28, 2023

Description

This PR removes the discontinuity check on the grid because iris.util.find_discontiguities realises the auxiliary coordinates
Closes #2117
Link to documentation:


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@sloosvel sloosvel added this to the v2.9.0 milestone Jun 28, 2023
@sloosvel sloosvel added the bug Something isn't working label Jun 28, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #2119 (58a61c4) into main (1101d36) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2119      +/-   ##
==========================================
- Coverage   93.09%   93.09%   -0.01%     
==========================================
  Files         237      237              
  Lines       12806    12794      -12     
==========================================
- Hits        11922    11910      -12     
  Misses        884      884              
Impacted Files Coverage Δ
esmvalcore/preprocessor/_regrid.py 98.25% <ø> (-0.06%) ⬇️

@bouweandela bouweandela merged commit 276c56c into main Jul 3, 2023
@bouweandela bouweandela deleted the dev_remove_discontinuity_check branch July 3, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove automatic setting of use_src_mask in regrid
2 participants