Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix for EC-Earth3-Veg tos calendar #2100

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Jun 19, 2023

Description

Converts the EC-Earth3-Veg tos calendar to proleptic_gregorian to make it possible to concatenate the historical experiment with the ssp126 experiment.

See #1731


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@bouweandela bouweandela added the fix for dataset Related to dataset-specific fix files label Jun 19, 2023
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #2100 (eb00840) into main (41f46ab) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2100   +/-   ##
=======================================
  Coverage   93.08%   93.09%           
=======================================
  Files         237      237           
  Lines       12793    12795    +2     
=======================================
+ Hits        11909    11911    +2     
  Misses        884      884           
Impacted Files Coverage Δ
esmvalcore/cmor/_fixes/cmip6/ec_earth3_veg.py 100.00% <100.00%> (ø)

@bouweandela bouweandela marked this pull request as ready for review June 19, 2023 10:21
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one! 🍺

@valeriupredoi valeriupredoi merged commit bbd4a23 into main Jun 22, 2023
@valeriupredoi valeriupredoi deleted the fix-ec-earth3-veg-tos branch June 22, 2023 12:31
@bouweandela bouweandela added this to the v2.9.0 milestone Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix for dataset Related to dataset-specific fix files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants