Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic HTML output for monitoring #2062

Merged
merged 57 commits into from
Oct 9, 2023
Merged

Dynamic HTML output for monitoring #2062

merged 57 commits into from
Oct 9, 2023

Conversation

bsolino
Copy link
Contributor

@bsolino bsolino commented May 24, 2023

Description

Closes #2059

Link to documentation:


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@bsolino bsolino self-assigned this May 24, 2023
@bsolino bsolino changed the title Added tabs for diagnostics Dynamic HTML output for monitoring May 24, 2023
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #2062 (0b9eb1e) into main (0b07b05) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2062      +/-   ##
==========================================
+ Coverage   93.27%   93.28%   +0.01%     
==========================================
  Files         238      238              
  Lines       12821    12843      +22     
==========================================
+ Hits        11959    11981      +22     
  Misses        862      862              
Files Coverage Δ
esmvalcore/experimental/recipe_output.py 84.12% <100.00%> (+2.09%) ⬆️

@bsolino bsolino added the enhancement New feature or request label Jun 13, 2023
@schlunma
Copy link
Contributor

Thanks @bsolino, I am looking forward to a nicer website!

Would it maybe be possible to provide screenshots or (better) a publicly available example website on our bot machine for this? This would make it much easier to test this. Thanks!

@bsolino
Copy link
Contributor Author

bsolino commented Jun 16, 2023

Thanks @bsolino, I am looking forward to a nicer website!

Would it maybe be possible to provide screenshots or (better) a publicly available example website on our bot machine for this? This would make it much easier to test this. Thanks!

Funny that you mention it, I'm working on that at this moment 😉
I wanted to make a comparison with the current output, but for a first peek you can see how it would look like for recipe_monitor.yml and recipe_monitor_with_refs.yml.

EDIT: The examples are available on the Issue: #2059

@bouweandela bouweandela mentioned this pull request Jun 16, 2023
10 tasks
@bsolino bsolino marked this pull request as ready for review September 8, 2023 16:09
@bsolino
Copy link
Contributor Author

bsolino commented Sep 8, 2023

The website has now been totally ported to Bootstrap for visuals and basic functionality, and with jQuery instead of JavaScript to improve compatibility across browsers. New screenshots and live demo are availables on the linked issue. Direct links to live demos:

For comparison:

@bsolino bsolino added this to the v2.10.0 milestone Sep 11, 2023
@bsolino bsolino requested a review from zklaus September 14, 2023 06:41
Copy link

@zklaus zklaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two change requests for the Python code. The templates and java script look ok to me, though I am not an expert.

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, cheers, @bsolino + reviewers! 🍻

@valeriupredoi valeriupredoi merged commit be1b790 into main Oct 9, 2023
@valeriupredoi valeriupredoi deleted the html_monitoring branch October 9, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic HTML output for monitoring
5 participants