-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic HTML output for monitoring #2062
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2062 +/- ##
==========================================
+ Coverage 93.27% 93.28% +0.01%
==========================================
Files 238 238
Lines 12821 12843 +22
==========================================
+ Hits 11959 11981 +22
Misses 862 862
|
…nto html_monitoring
Thanks @bsolino, I am looking forward to a nicer website! Would it maybe be possible to provide screenshots or (better) a publicly available example website on our bot machine for this? This would make it much easier to test this. Thanks! |
Funny that you mention it, I'm working on that at this moment 😉 EDIT: The examples are available on the Issue: #2059 |
The website has now been totally ported to Bootstrap for visuals and basic functionality, and with jQuery instead of JavaScript to improve compatibility across browsers. New screenshots and live demo are availables on the linked issue. Direct links to live demos: For comparison:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two change requests for the Python code. The templates and java script look ok to me, though I am not an expert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work, cheers, @bsolino + reviewers! 🍻
Description
Closes #2059
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: