remove unneeded sphinxcontrib extension - sphinxcontrib.jquery
#2047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2047 +/- ##
=======================================
Coverage 92.79% 92.79%
=======================================
Files 236 236
Lines 12484 12484
=======================================
Hits 11585 11585
Misses 899 899 |
|
@bouweandela you were right! Docs build well at Readthedocs and search works just fine too, without the extension - however, docs build fails with something I got no clue about on Circle (install works fine though) - help! also @zklaus |
|
@bouweandela you remember that pointer you gave me how to fix the current fail? Beats me if I can find it anywhere, could you repost plsss 🍺 |
|
You could try adding |
ah that was the one, thanks, man! 🍺 |
|
@bouweandela that worked smoother than a baby's bottom, cheers 🍺 Can I haz a review pls? |
bouweandela
requested changes
May 23, 2023
bouweandela
approved these changes
May 23, 2023
|
cheers, bud 🍺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following @bouweandela 's suggestion to get rid of that extension, since we have a new sphinx theme now.
Closes #2035
Link to documentation: example of docs built correctly and search working well (for "cmip" keyword) here
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: