Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect ignore_warnings settings in Dataset.load #2046

Merged
merged 5 commits into from
Jun 1, 2023

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented May 19, 2023

Description

This PR fixes an issue where ignored warnings defined in the config-developer.yml file are ignored by Dataset.load.

Closes #2045

Link to documentation: https://esmvaltool--2046.org.readthedocs.build/projects/ESMValCore/en/2046/api/esmvalcore.dataset.html#esmvalcore.dataset.Dataset.load


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added the bug Something isn't working label May 19, 2023
@schlunma schlunma added this to the v2.9.0 milestone May 19, 2023
@schlunma schlunma requested a review from bouweandela May 19, 2023 10:52
@schlunma schlunma self-assigned this May 19, 2023
@schlunma schlunma force-pushed the fix_ignore_warnings branch from 7238ce6 to a21ef73 Compare May 19, 2023 11:38
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #2046 (590b3fa) into main (153c3a8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2046   +/-   ##
=======================================
  Coverage   92.90%   92.90%           
=======================================
  Files         234      234           
  Lines       12496    12501    +5     
=======================================
+ Hits        11609    11614    +5     
  Misses        887      887           
Impacted Files Coverage Δ
esmvalcore/_recipe/recipe.py 99.01% <ø> (-0.02%) ⬇️
esmvalcore/config/_config.py 98.91% <100.00%> (+0.14%) ⬆️
esmvalcore/dataset.py 100.00% <100.00%> (ø)
esmvalcore/preprocessor/_supplementary_vars.py 98.05% <100.00%> (+0.03%) ⬆️

Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this issue @schlunma!

@schlunma schlunma force-pushed the fix_ignore_warnings branch from a21ef73 to f74cc44 Compare May 19, 2023 13:52
@remi-kazeroni remi-kazeroni merged commit f656483 into main Jun 1, 2023
@remi-kazeroni remi-kazeroni deleted the fix_ignore_warnings branch June 1, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ignore_warnings in cfg-developer.yml is not considered anymore
3 participants