-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for hourly ICON data #1990
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1990 +/- ##
=======================================
Coverage 92.79% 92.80%
=======================================
Files 236 236
Lines 12438 12445 +7
=======================================
+ Hits 11542 11549 +7
Misses 896 896
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BauerJul for this great contribution! I tested this on real ICON data and it works very well; we can finally read hourly ICON data now! 🚀
A couple of very minor comments below about comments and line breaks. After that I will approve 👍
Co-authored-by: Manuel Schlund <32543114+schlunma@users.noreply.github.com>
Co-authored-by: Manuel Schlund <32543114+schlunma@users.noreply.github.com>
Co-authored-by: Manuel Schlund <32543114+schlunma@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, great stuff @BauerJul 🚀 Re-tested this with real ICON data, everything works flawlessly. This can be merged!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice indeed! Just one text remark for the (very nicely) in-line commented code, which I am going to commit to spare you the extra hassle. Also, if you have an ORCID number you can add it later, no bother if you don't have one. Cheers 🍺
- | ||
affiliation: "DLR, Germany" | ||
family-names: Bauer | ||
given-names: Julian |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BauerJul do you have an ORCID number by any chance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@valeriupredoi I do not have an ORCID number yet
tests fail because of #1982 - nothing to do with this PR 👍 |
Thanks a lot for fixing the comment and for approving! @valeriupredoi |
Description
This pull request adds support for hourly ICON data. The old version of the code did not support this yet.
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: