Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for hourly ICON data #1990

Merged
merged 11 commits into from
Apr 18, 2023
Merged

Add support for hourly ICON data #1990

merged 11 commits into from
Apr 18, 2023

Conversation

BauerJul
Copy link
Contributor

@BauerJul BauerJul commented Mar 29, 2023

Description

This pull request adds support for hourly ICON data. The old version of the code did not support this yet.

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@BauerJul BauerJul added the enhancement New feature or request label Mar 29, 2023
@BauerJul BauerJul added this to the v2.9.0 milestone Mar 29, 2023
@BauerJul BauerJul requested a review from schlunma March 29, 2023 14:43
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #1990 (1b9aa15) into main (72b4169) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 1b9aa15 differs from pull request most recent head 2f1f1bb. Consider uploading reports for the commit 2f1f1bb to get more accurate results

@@           Coverage Diff           @@
##             main    #1990   +/-   ##
=======================================
  Coverage   92.79%   92.80%           
=======================================
  Files         236      236           
  Lines       12438    12445    +7     
=======================================
+ Hits        11542    11549    +7     
  Misses        896      896           
Impacted Files Coverage Δ
esmvalcore/cmor/_fixes/icon/icon.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BauerJul for this great contribution! I tested this on real ICON data and it works very well; we can finally read hourly ICON data now! 🚀

A couple of very minor comments below about comments and line breaks. After that I will approve 👍

BauerJul and others added 3 commits April 3, 2023 10:09
Co-authored-by: Manuel Schlund <32543114+schlunma@users.noreply.github.com>
Co-authored-by: Manuel Schlund <32543114+schlunma@users.noreply.github.com>
Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, great stuff @BauerJul 🚀 Re-tested this with real ICON data, everything works flawlessly. This can be merged!

@valeriupredoi
Copy link
Contributor

many thanks @BauerJul and @schlunma - I'll have a quick look over myself now, and will merge 🍺

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice indeed! Just one text remark for the (very nicely) in-line commented code, which I am going to commit to spare you the extra hassle. Also, if you have an ORCID number you can add it later, no bother if you don't have one. Cheers 🍺

-
affiliation: "DLR, Germany"
family-names: Bauer
given-names: Julian
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BauerJul do you have an ORCID number by any chance?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valeriupredoi I do not have an ORCID number yet

@valeriupredoi valeriupredoi added the cmor Related to the CMOR standard label Apr 18, 2023
@valeriupredoi
Copy link
Contributor

tests fail because of #1982 - nothing to do with this PR 👍

@valeriupredoi valeriupredoi merged commit 3cac50a into main Apr 18, 2023
@valeriupredoi valeriupredoi deleted the fix_icon_hourly branch April 18, 2023 15:24
@BauerJul
Copy link
Contributor Author

Thanks a lot for fixing the comment and for approving! @valeriupredoi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmor Related to the CMOR standard enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants