-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Fix.session
to access Session
in fixes
#1988
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1988 +/- ##
=======================================
Coverage 92.79% 92.79%
=======================================
Files 236 236
Lines 12484 12485 +1
=======================================
+ Hits 11585 11586 +1
Misses 899 899
|
valeriupredoi
approved these changes
May 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two small comments that don't warrant a rejection 😁 Cheers, bud 🍺
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To make fixes even more flexible I added a
session
attribute which includes the currentSession
. Example use case is loading additional data in the fix from theauxiliary_data_dir
, which can now be accessed viaFix.session['auxiliary_data_dir']
.Closes #1986
Link to documentation: https://esmvaltool--1988.org.readthedocs.build/projects/ESMValCore/en/1988/develop/fixing_data.html#fix-structure
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
All checks below this pull request were successful(Codacy issues cannot be fixed)To help with the number pull requests: