-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make extract_volume work with closed and mixed intervals and allow nearest value selection #1930
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1930 +/- ##
=======================================
Coverage 92.64% 92.65%
=======================================
Files 236 236
Lines 12402 12417 +15
=======================================
+ Hits 11490 11505 +15
Misses 912 912
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! I'd like to see the explanation of whan a left/right open interval means in terms of the operation itself ie closed: <=/>=
and open:</>
but that's just nitpicking at this late stage before the freeze 🍺
No worries I can add now a short explanation |
if you could that'd be nice - pls merge main into here too, hoping no merge conflicts. Cheers Saskia 🍺 |
Description
This PR expands the capabilities of
extract_volume
so that it works with closed and mixed intervals. It also adds the possibility to perform the extraction taking into account the coordinate values.There is also a small fix in the documentation regarding a link that was not pointing to the right function.
Closes #1926
Link to documentation: https://esmvaltool--1930.org.readthedocs.build/projects/ESMValCore/en/1930/recipe/preprocessor.html#extract-volume
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
- [ ] 🛠 Any changed dependencies have been added or removed correctlyTo help with the number pull requests: