Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make extract_volume work with closed and mixed intervals and allow nearest value selection #1930

Merged
merged 19 commits into from
Mar 1, 2023

Conversation

sloosvel
Copy link
Contributor

@sloosvel sloosvel commented Feb 14, 2023

Description

This PR expands the capabilities of extract_volume so that it works with closed and mixed intervals. It also adds the possibility to perform the extraction taking into account the coordinate values.

There is also a small fix in the documentation regarding a link that was not pointing to the right function.

Closes #1926

Link to documentation: https://esmvaltool--1930.org.readthedocs.build/projects/ESMValCore/en/1930/recipe/preprocessor.html#extract-volume


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #1930 (96d9446) into main (40e00e8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1930   +/-   ##
=======================================
  Coverage   92.64%   92.65%           
=======================================
  Files         236      236           
  Lines       12402    12417   +15     
=======================================
+ Hits        11490    11505   +15     
  Misses        912      912           
Impacted Files Coverage Δ
esmvalcore/preprocessor/_volume.py 90.43% <100.00%> (+1.43%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sloosvel sloosvel added the preprocessor Related to the preprocessor label Feb 23, 2023
@sloosvel sloosvel marked this pull request as ready for review February 23, 2023 12:16
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I'd like to see the explanation of whan a left/right open interval means in terms of the operation itself ie closed: <=/>= and open:</> but that's just nitpicking at this late stage before the freeze 🍺

@sloosvel
Copy link
Contributor Author

sloosvel commented Mar 1, 2023

No worries I can add now a short explanation

@valeriupredoi
Copy link
Contributor

if you could that'd be nice - pls merge main into here too, hoping no merge conflicts. Cheers Saskia 🍺

@sloosvel sloosvel added this to the v2.8.0 milestone Mar 1, 2023
@valeriupredoi valeriupredoi added the enhancement New feature or request label Mar 1, 2023
@valeriupredoi valeriupredoi merged commit f03fcbd into main Mar 1, 2023
@valeriupredoi valeriupredoi deleted the dev_extract_volume branch March 1, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request preprocessor Related to the preprocessor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Behaviour of extract_volume - allow extraction on closed or mixed intervals
2 participants