Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve resilience of ESGF search #1869

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Dec 12, 2022

Description

Closes #1867


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@bouweandela bouweandela added the bug Something isn't working label Dec 12, 2022
@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #1869 (e016ed6) into main (6b9a95d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1869      +/-   ##
==========================================
- Coverage   91.51%   91.49%   -0.02%     
==========================================
  Files         209      209              
  Lines       11340    11340              
==========================================
- Hits        10378    10376       -2     
- Misses        962      964       +2     
Impacted Files Coverage Δ
esmvalcore/esgf/_search.py 100.00% <100.00%> (ø)
esmvalcore/preprocessor/_regrid.py 96.56% <0.00%> (-0.63%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bouweandela bouweandela marked this pull request as ready for review December 12, 2022 14:36
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bouweandela
Copy link
Member Author

@ESMValGroup/technical-lead-development-team Could someone please do a final check and merge?

@bouweandela bouweandela added this to the v2.8.0 milestone Dec 13, 2022
@valeriupredoi
Copy link
Contributor

valeriupredoi commented Jan 9, 2023

Yo @ESMValGroup/technical-lead-development-team fire up yer behinds and have a looksee and merge this one please 🍺

@schlunma schlunma merged commit d6373e7 into main Jan 9, 2023
@schlunma schlunma deleted the fix-esgf-search-fallback branch January 9, 2023 12:38
@valeriupredoi
Copy link
Contributor

cheers Manu "Pheidippides" Schlund 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESGF search fallback if index node is offline is still not working correctly
3 participants