Add standard variable names for EMAC #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranziskaWinterstein
added
bug
Codecov Report
@@ Coverage Diff @@
## main #1853 +/- ##
=======================================
Coverage 91.51% 91.51%
=======================================
Files 209 209
Lines 11336 11336
=======================================
Hits 10374 10374
Misses 962 962
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
schlunma
approved these changes
Dec 9, 2022
There was a problem hiding this comment.
Looks good to me, thanks for adding those 😊
@remi-kazeroni would you be able to do a final check and merge, please? Thanks!!
|
Thanks for your contribution @FranziskaWinterstein and for the review @schlunma! That looks good to me as well 👍 |
remi-kazeroni
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The applied changes add the default variable name of EMAC to the derived variables included in _fixes/emac/emac.py (without the _ave).
I decided to put the default variable name (without _ave) last, since the _ave is most often used to derive monthly means. If both variable are available, the monthly average calculated by the model itself is used instead of the average of the instantaneous output produced by post-processing. Although there should not be a difference in most cases.
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.