Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CEDA ESGF index node hostname #1838

Merged
merged 9 commits into from
Dec 5, 2022
Merged

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Nov 29, 2022

Description

Kind info provided by @alaniwi - many thanks, Alan!


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@valeriupredoi valeriupredoi added documentation Improvements or additions to documentation testing labels Nov 29, 2022
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #1838 (47ed378) into main (5180b4f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1838   +/-   ##
=======================================
  Coverage   91.54%   91.54%           
=======================================
  Files         203      203           
  Lines       10945    10945           
=======================================
  Hits        10020    10020           
  Misses        925      925           
Impacted Files Coverage Δ
esmvalcore/config/_esgf_pyclient.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @valeriupredoi!

@bouweandela bouweandela changed the title Update ceda esgf node name Update CEDA ESGF index node name Nov 29, 2022
@bouweandela bouweandela changed the title Update CEDA ESGF index node name Update CEDA ESGF index node hostname Nov 29, 2022
@valeriupredoi
Copy link
Contributor Author

hi @bouweandela sorry for the back and forthing, I have now reverted those two changes in test search, bud 🍺

Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now, thanks!

@valeriupredoi
Copy link
Contributor Author

cheers muchly @bouweandela 🍺 Since this is a boring old structure PR, and has been thoroughly reviewed by Bouwe, I'll be the merger too 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants