-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CEDA ESGF index node hostname #1838
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1838 +/- ##
=======================================
Coverage 91.54% 91.54%
=======================================
Files 203 203
Lines 10945 10945
=======================================
Hits 10020 10020
Misses 925 925
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this @valeriupredoi!
tests/integration/esgf/search_results/Amon_r1i1p1_historical,rcp85_INM-CM4_CMIP5_tas.json
Show resolved
Hide resolved
hi @bouweandela sorry for the back and forthing, I have now reverted those two changes in test search, bud 🍺 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now, thanks!
cheers muchly @bouweandela 🍺 Since this is a boring old structure PR, and has been thoroughly reviewed by Bouwe, I'll be the merger too 👍 |
Description
Kind info provided by @alaniwi - many thanks, Alan!
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: