Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added scalar coords of input cubes to output of esmpy_regrid #1811

Merged
merged 2 commits into from
Nov 23, 2022

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Nov 18, 2022

Description

This PR adds missing scalar coordinates of the input cubes to the output of esmpy_regrid and fixes a bunch of Codacy issues in the corresponding files.

Closes #1810


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added the bug Something isn't working label Nov 18, 2022
@schlunma schlunma added this to the v2.8.0 milestone Nov 18, 2022
@schlunma schlunma requested a review from zklaus November 18, 2022 13:50
@schlunma schlunma self-assigned this Nov 18, 2022
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #1811 (3b42636) into main (a6f8c08) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1811      +/-   ##
==========================================
- Coverage   91.51%   91.49%   -0.02%     
==========================================
  Files         202      202              
  Lines       10908    10910       +2     
==========================================
  Hits         9982     9982              
- Misses        926      928       +2     
Impacted Files Coverage Δ
esmvalcore/preprocessor/_regrid.py 97.11% <100.00%> (ø)
esmvalcore/preprocessor/_regrid_esmpy.py 89.88% <100.00%> (+0.11%) ⬆️
esmvalcore/cmor/check.py 97.38% <0.00%> (-0.38%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@schlunma
Copy link
Contributor Author

@zklaus would you be able to have a quick look at that? This is blocking me from #1808. Thanks 👍

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, cheeers, Manu! Just a bit of a nicer handling of an empty array/tuple

@sloosvel
Copy link
Contributor

Nice!

@sloosvel sloosvel merged commit 5644203 into main Nov 23, 2022
@sloosvel sloosvel deleted the fix_esmpy_regrid_scalar_coords branch November 23, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Irregular regridding with our custom esmpy regridder drops scalar coordinates
3 participants