Remove outdated cmor_table facet from data finder tests

[bouweandela]

Description

This removes the cmor_table facet from the esmvalcore/_data_finder.py tests. A long time ago, the CMOR table could be different from the project. This is no longer the case, so it can be removed.

This also adds hist to the list of ignored spelling mistakes, because that raised incorrect warnigns with the pre-commit hook for codespell while trying to commit this change.

Part of #1609

---

Before you get started

• ☝ Create an issue to discuss what you are going to do

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

• 🧪 The new functionality is relevant and scientifically sound
• 🛠 This pull request has a descriptive title and labels
• 🛠 Code is written according to the code quality guidelines
• 🛠 Unit tests have been added
• 🛠 Changes are backward compatible
• 🛠 The list of authors is up to date
• 🛠 All checks below this pull request were successful

---

To help with the number pull requests:

• 🙏 We kindly ask you to review two other open pull requests in this repository

[codecov]

Codecov Report

Merging #1798 (1027eaf) into main (4d48ece) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1798   +/-   ##
=======================================
  Coverage   91.51%   91.51%           
=======================================
  Files         202      202           
  Lines       10908    10908           
=======================================
  Hits         9982     9982           
  Misses        926      926           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[valeriupredoi]

the CMOR table could be different from the project

it still is, I don't understand this - CMIP5 CMOR tables are totally different from CMIP6 CMOR tables, it's just that the handling is done better on our side

[valeriupredoi]

thanks @bouweandela 🍺 There are some more instances of cmor_table in tests/integration/test_recipe.py - do we still need those?

[bouweandela]

Yes, they are function arguments to preprocessor functions

[bouweandela]

@ESMValGroup/technical-lead-development-team could someone please do a final check and merge?

[sloosvel]

A long time ago, the CMOR table could be different from the project. This is no longer the case, so it can be removed.

What do you mean by that? For convenience, internally we have a project that has a certain name but that follows a version of the CMIP6 tables. These changes only affect the tests, but is any further work going to affect the ability of having custom named projects that may follow tables that don't have the same name?

[valeriupredoi]

A long time ago, the CMOR table could be different from the project. This is no longer the case, so it can be removed.

What do you mean by that? For convenience, internally we have a project that has a certain name but that follows a version of the CMIP6 tables. These changes only affect the tests, but is any further work going to affect the ability of having custom named projects that may follow tables that don't have the same name?

This is getting all X-Files now, guys - I was a bit puzzlated by what Bouwe was on about too, but since this is just some test fixing, I thinks it's OK

[bouweandela]

A long time ago, the CMOR table could be different from the project. This is no longer the case, so it can be removed.

What do you mean by that?

I mean that the cmor_table facet is not used anywhere in the code. All uses of it were removed in #358, but even then it was already the same as the project facet for quite some time. When we were just writing version 2, you could specify {project: OBS, cmor_table: CMIP5}, you could dig into the git history if you want to know more..

is any further work going to affect the ability of having custom named projects that may follow tables that don't have the same name?

No. I need to make some changes to esmvalcore/_data_finder.py in #1609 to support wildcard searches, that's why I was looking at the tests and noticed this bit of ancient history and decided to remove it.

[sloosvel]

Great, thanks! I will merge now