Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore support for scalar cubes to time selection preprocessor functions #1750

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Oct 6, 2022

Description

Restore support for scalar cubes to time selection preprocessor functions.

Closes #1743


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@bouweandela bouweandela added the bug Something isn't working label Oct 6, 2022
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #1750 (db3ff99) into main (77612eb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1750   +/-   ##
=======================================
  Coverage   91.17%   91.17%           
=======================================
  Files         202      202           
  Lines       10887    10890    +3     
=======================================
+ Hits         9926     9929    +3     
  Misses        961      961           
Impacted Files Coverage Δ
esmvalcore/preprocessor/_time.py 97.70% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bouweandela bouweandela requested a review from schlunma October 6, 2022 09:22
@bouweandela bouweandela marked this pull request as ready for review October 6, 2022 09:22
Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @bouweandela! Tested successfully on real data with resample_time.

@valeriupredoi
Copy link
Contributor

very cool! I am going to plug this in the next rc (which is probably gonna be the stable version) 🥳

@valeriupredoi valeriupredoi added this to the v2.7.0 milestone Oct 7, 2022
@valeriupredoi
Copy link
Contributor

@bouweandela you mind turning the GA just for a fleeing second pls so we don't run into the lower Pythons complaining again?

@bouweandela
Copy link
Member Author

bouweandela commented Oct 7, 2022

The problem was with type hints, using | instead of typing.Union is only supported since Python 3.10. Since this pull request does not introduce any type hints, it seems unlikely that there will be a problem.

Anyway, didn't you configure the GitHub actions such that you could trigger them with a comment or something?

@valeriupredoi
Copy link
Contributor

aha gotcha! Gonna merge w/o it then, I'll keep an eye for hints of failure 🐍 Yeah I did, but I had to deactivate the test - you can activate the test, trigger them by comment (beats me what comment it was though 😆 _, then deactivate the test again, coz if it stays active then that will run on an any other PR - GitHub devs were extremely useful and told me that bug will not be fixed in the near future. Thanks, GitHub!

@valeriupredoi valeriupredoi merged commit bbfa305 into main Oct 7, 2022
@valeriupredoi valeriupredoi deleted the time-scalar-cubes branch October 7, 2022 14:37
@valeriupredoi
Copy link
Contributor

cheers @bouweandela 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check for scalar cubes in time operations and improve error handling/messaging in light of #1713
3 participants