-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore support for scalar cubes to time selection preprocessor functions #1750
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1750 +/- ##
=======================================
Coverage 91.17% 91.17%
=======================================
Files 202 202
Lines 10887 10890 +3
=======================================
+ Hits 9926 9929 +3
Misses 961 961
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @bouweandela! Tested successfully on real data with resample_time
.
very cool! I am going to plug this in the next rc (which is probably gonna be the stable version) 🥳 |
@bouweandela you mind turning the GA just for a fleeing second pls so we don't run into the lower Pythons complaining again? |
The problem was with type hints, using Anyway, didn't you configure the GitHub actions such that you could trigger them with a comment or something? |
aha gotcha! Gonna merge w/o it then, I'll keep an eye for hints of failure 🐍 Yeah I did, but I had to deactivate the test - you can activate the test, trigger them by comment (beats me what comment it was though 😆 _, then deactivate the test again, coz if it stays active then that will run on an any other PR - GitHub devs were extremely useful and told me that bug will not be fixed in the near future. Thanks, GitHub! |
cheers @bouweandela 🍺 |
Description
Restore support for scalar cubes to time selection preprocessor functions.
Closes #1743
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: