-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add derivation of sea ice extent #1695
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1695 +/- ##
==========================================
+ Coverage 91.16% 91.18% +0.02%
==========================================
Files 202 203 +1
Lines 10882 10908 +26
==========================================
+ Hits 9921 9947 +26
Misses 961 961
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Hi @dhohn , this is now ready to be reviewed. Do you think you could test the changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ive made a couple plots which look correct. I also tried a model (ACCESS) that provides both siconc
and siconca
, which also works.
Thanks @dhohn ! @ESMValGroup/technical-lead-development-team anyone with time to merge? I can do it if there are no further comments, but since we agreed ond having the merger be different than the reviewer I thought I would ask. |
I would have been happy to do it. Maybe you could wait a bit longer next time, to give people an opportunity to respond to your question? |
ups, will do! sorry |
Description
This PR allows to compute the sea ice extent as a derived variable in order to reduce the amount of saved data during the preprocessing
Closes #1693
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
- [ ] 🧪 and 🛠 Documentation is available- [ ] 🛠 Any changed dependencies have been added or removed correctlyTo help with the number pull requests: