Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Github Actions dashboard badge from meercode.io #1640

Merged
merged 4 commits into from
Jun 28, 2022

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Jun 21, 2022

It's good to have CI Dashboard badges so we can have a bird's eye view of what our CI/CD is doing - @bouweandela pointed me to a dashboard from Circle, so I thought I'd have a go at a dash from Github Actions - proves out GA don't have a native dashboard so I found meercode.io offers a very decent integration (not only for GA) - can one of you @bouweandela @zklaus @schlunma please test if the badge is leading to the correct dashboard - it does for me, but I am registered with meercode, so not sure if that's working overall. Cheers 🍺

UPDATE at point of moving it to Ready for Review

Folks see plots and stats and all manners of dashboard-y stuff if they click on the Meercode badge, and autheticate with GitHub. Do we need documentation for this? I think we're fine like this -

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #1640 (e16bca4) into main (551bd30) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1640   +/-   ##
=======================================
  Coverage   91.49%   91.49%           
=======================================
  Files         204      204           
  Lines       11175    11175           
=======================================
  Hits        10225    10225           
  Misses        950      950           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 551bd30...e16bca4. Read the comment docs.

@zklaus
Copy link

zklaus commented Jun 21, 2022

Looks good. I got a badge that says "success rate 91%".

@schlunma
Copy link
Contributor

Looks good. I got a badge that says "success rate 91%".

Same here 👍

@valeriupredoi
Copy link
Contributor Author

yeah cheers guys, but what do you get when you click on that badge? You should get a Dashboard with a lot of plots and info once you've logged in with yer GitHub credentials

@valeriupredoi
Copy link
Contributor Author

yeah cheers guys, but what do you get when you click on that badge? You should get a Dashboard with a lot of plots and info once you've logged in with yer GitHub credentials

any luck with this, fellas? 🍺

@bouweandela
Copy link
Member

Clicking the badge does not work that well for me. I first need to authorize the app to use my github account or I see nothing. After authorization, I do see white blobs representing the various test runs, but no plots or anything.

@schlunma
Copy link
Contributor

Yes, same here:

image

I think they're having some issues, as the Badge disappeared for me and the link of the badge (https://api.meercode.io/badge/ESMValGroup/ESMValCore?type=ci-success-rate&branch=main&lastDay=14) returns an "Internal server error".

@valeriupredoi
Copy link
Contributor Author

I can see this - complete with sidebar menu where I can select all manners of plots - did you guys activate your membership with Meercode?
meerCrap

@schlunma
Copy link
Contributor

I see this too, but clicking on the cards does nothing. Also, the fancy options on the left (e.g., summary) don't show anything.

@bouweandela
Copy link
Member

@valeriupredoi That's what it looks like for me too, but note that not even the branch names are filled in: it looks like all actual data is missing from the cards.

@valeriupredoi
Copy link
Contributor Author

OK cool! Progress! It seems they are indeed going through the bushes since I don't see any plots, data etc either - but normally one should be able to see that stuff, will check if they have some status report like GitHub - cheers for trying, guys!

@valeriupredoi
Copy link
Contributor Author

I sent some feedback to the devs, will get back to you guys when this starts working again - you fellas decided to test it right when it went belly up 🤣

@valeriupredoi
Copy link
Contributor Author

OK plots are back for me, and I switched the dark mode on and they look super badass, can you fellas try again as well, please? I'll convert it to a RfR PR then 🍻

@valeriupredoi
Copy link
Contributor Author

nasa-stuff

@schlunma
Copy link
Contributor

Yes, I can see the same now 🚀

@valeriupredoi
Copy link
Contributor Author

cheers, Manu! Pretty nifty these plots aren't they?

@valeriupredoi valeriupredoi marked this pull request as ready for review June 28, 2022 14:47
Copy link

@zklaus zklaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I am a bit weary since it's not super tied to the project but just invites everyone to join meercode and there may be other projects sprinkled in, but why not try it out for a bit. I like the idea of having a dashboard that collates GH Actions and CircleCI in one place.

@valeriupredoi
Copy link
Contributor Author

valeriupredoi commented Jun 28, 2022

cheers much @zklaus 🍺

I am a bit weary since it's not super tied to the project but just invites everyone to join meercode and there may be other projects sprinkled in

nay worry, I did the initial configuration for the ESMValGroup/ESMValCore being an admin of the repo, I don't think anyone can willingly add bits and bobs if they're not admins

Circle is not yet added to the Meercode, do we want to add it? (not sure it's even possible tho)

@zklaus
Copy link

zklaus commented Jun 28, 2022

What I mean is that what you see on meercode.io is determined by your user account, not only by project configuration. But don't worry. I don't consider it a blocker.

@valeriupredoi
Copy link
Contributor Author

ah yeah fair enough - got it now. Meh, I guess that's fine for us few that will want to look at these things, pretty sure 85% of our users will not want to see/add all manners of plots anyway 😁

@valeriupredoi valeriupredoi merged commit c208e5d into main Jun 28, 2022
@valeriupredoi valeriupredoi deleted the test_dashboard_badge branch June 28, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants